New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'git mv' command integration into browser #239

Closed
OmegaPhil opened this Issue Mar 16, 2014 · 5 comments

Comments

Projects
None yet
4 participants
@OmegaPhil

OmegaPhil commented Mar 16, 2014

Please could the 'git mv' command be integrated into the browser (or other useful place) in git-cola?

Thanks

@ulgens

This comment has been minimized.

Show comment
Hide comment
@ulgens

ulgens Apr 12, 2014

Is git-cola an editor? I think moving a file is a feature of an editor and if we say git-cola is not an editor; it shouldn't be a part of this software.

ulgens commented Apr 12, 2014

Is git-cola an editor? I think moving a file is a feature of an editor and if we say git-cola is not an editor; it shouldn't be a part of this software.

@OmegaPhil

This comment has been minimized.

Show comment
Hide comment
@OmegaPhil

OmegaPhil Apr 12, 2014

git-cola is not an editor, neither is git - this is just a point about something git does that git-cola does not (I was testing out not using git and just using git-cola for a period).

If you want to argue about it then you can say that git can already detect renames, so integrated move is not necessary - but that leaves the question of why they implemented mv in git in the first place.

OmegaPhil commented Apr 12, 2014

git-cola is not an editor, neither is git - this is just a point about something git does that git-cola does not (I was testing out not using git and just using git-cola for a period).

If you want to argue about it then you can say that git can already detect renames, so integrated move is not necessary - but that leaves the question of why they implemented mv in git in the first place.

@Vdragon

This comment has been minimized.

Show comment
Hide comment
@Vdragon

Vdragon Jun 5, 2014

Contributor

As long as Dolphin file manager don't support git mv I'd really like this feature to be in git-cola's browser, IMO

Contributor

Vdragon commented Jun 5, 2014

As long as Dolphin file manager don't support git mv I'd really like this feature to be in git-cola's browser, IMO

@davvid davvid added the wishlist label Jun 5, 2014

@davvid

This comment has been minimized.

Show comment
Hide comment
@davvid

davvid Jun 5, 2014

Member

Yeah, it wouldn't hurt to have it integrated. Right now we show moves as a removal and an addition. That'd be acceptable for a first try at integrating "git mv", though, since it at least makes the feature available.

Maybe right-click on a path in the Browser and have an action called "Move..." which pops up a "save file"-like dialog where you can choose the new path. If they right-click a folder then it should be a "Choose folder" dialog that's restricted to new directories only.

Member

davvid commented Jun 5, 2014

Yeah, it wouldn't hurt to have it integrated. Right now we show moves as a removal and an addition. That'd be acceptable for a first try at integrating "git mv", though, since it at least makes the feature available.

Maybe right-click on a path in the Browser and have an action called "Move..." which pops up a "save file"-like dialog where you can choose the new path. If they right-click a folder then it should be a "Choose folder" dialog that's restricted to new directories only.

davvid added a commit to davvid/git-cola that referenced this issue Mar 12, 2018

gitcmds: simplify listdir() by building upon os.listdir()
Related-to: #239
Signed-off-by: David Aguilar <davvid@gmail.com>

davvid added a commit to davvid/git-cola that referenced this issue Mar 12, 2018

interaction: add a save_as() command
Related-to: #239
Signed-off-by: David Aguilar <davvid@gmail.com>

davvid added a commit to davvid/git-cola that referenced this issue Mar 12, 2018

cmds: add a "Rename" command
Related-to: #239
Signed-off-by: David Aguilar <davvid@gmail.com>

@davvid davvid closed this in 1a1e6e5 Mar 12, 2018

@ulgens

This comment has been minimized.

Show comment
Hide comment
@ulgens

ulgens Mar 12, 2018

That's hilarious to see how my idea changed in 3 years 😄 I think now it's an important feature, thanks! 🎉

ulgens commented Mar 12, 2018

That's hilarious to see how my idea changed in 3 years 😄 I think now it's an important feature, thanks! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment