New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View history from the File Browser throws exception #274

Closed
wengole opened this Issue Jun 6, 2014 · 1 comment

Comments

Projects
None yet
2 participants
@wengole

wengole commented Jun 6, 2014

Traceback (most recent call last):
  File "/usr/share/git-cola/lib/cola/widgets/browse.py", line 358, in view_history
    cmds.do(cmds.VisualizePaths, entries)
  File "/usr/share/git-cola/lib/cola/cmds.py", line 1311, in do
    return do_cmd(cls(*args, **opts))
  File "/usr/share/git-cola/lib/cola/cmds.py", line 1241, in __init__
    self.argv = browser + paths
TypeError: can only concatenate list (not "map") to list

I have a "fix" for this. I'm not entirely sure of the underlying problem, but I've worked around it. Will submit a pull request

wengole added a commit to wengole/git-cola that referenced this issue Jun 6, 2014

@wengole wengole referenced this issue Jun 6, 2014

Closed

Fix for #274 #275

@davvid davvid closed this in 2fc8fc8 Jun 7, 2014

@davvid

This comment has been minimized.

Show comment
Hide comment
@davvid

davvid Jun 7, 2014

Member

Thanks for the fix. I ended up wrapping the map() with list() at the call-site. You're on Python3, correct?

Member

davvid commented Jun 7, 2014

Thanks for the fix. I ended up wrapping the map() with list() at the call-site. You're on Python3, correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment