Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context menu in the "Bookmark" panel -> "Edit" tries to open a directory in a text-editor #281

Closed
Vdragon opened this issue Jun 7, 2014 · 1 comment

Comments

@Vdragon
Copy link
Contributor

Vdragon commented Jun 7, 2014

Reproduce steps

  1. _085
  2. click

Expected behavior?

Probably edit the repository's path...

Current behavior

git-cola launches a text editor tries to open the repository's directory(and in most editors, errors)

@davvid
Copy link
Member

davvid commented Jun 7, 2014

In my editor (vim, gvim) it lets me choose files from that directory. I think this menu item should say "Launch Editor" using cmds.LaunchEditor.name().

The "Edit" most users would think of would be to edit the bookmarks list, which is hidden under "+" and should probably be exposed here as well. We can improve that, I'll have a fix shortly.

davvid added a commit to davvid/git-cola that referenced this issue Jun 7, 2014
The "Edit" action was really "Launch Editor", so the menu action
explicitly to avoid ambiguities.

Add a new "Edit" action that actually edits the bookmarks list, which is
what most users would expect when clicking on "Edit".

Closes git-cola#281

Reported-by: V字龍(Vdragon) <pika1021@gmail.com>
Signed-off-by: David Aguilar <davvid@gmail.com>
@davvid davvid closed this as completed in c0120be Jun 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants