-
-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failed to run git-cola if the PATH environment variable contains non-ASCII characters #282
Comments
davvid
added a commit
to davvid/git-cola
that referenced
this issue
Jun 7, 2014
On Python2 we have to encode provide utf-8 bytestrings if we want unicode values in enviornment variables. Python3 accepts them as-is. Related-to: git-cola#282 Reported-by: V字龍(Vdragon) <pika1021@gmail.com> Signed-off-by: David Aguilar <davvid@gmail.com>
davvid
added a commit
to davvid/git-cola
that referenced
this issue
Jun 7, 2014
Decode the bytestring so that os.path.join() can operate on it now that we're using unicode literals. Closes git-cola#282 Reported-by: V字龍(Vdragon) <pika1021@gmail.com> Signed-off-by: David Aguilar <davvid@gmail.com>
davvid
added a commit
that referenced
this issue
Jun 7, 2014
On Python2 we have to encode provide utf-8 bytestrings if we want unicode values in enviornment variables. Python3 accepts them as-is. Related-to: #282 Reported-by: V字龍(Vdragon) <pika1021@gmail.com> Signed-off-by: David Aguilar <davvid@gmail.com>
I typod the closes line. This was actually fixed in 3084fe2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reproduce steps
$ make prefix=軟體/git-cola install
$ PATH=$PATH:$(pwd)/軟體/git-cola/bin
$ git cola
Expected result
git-cola launches normally
Current result
git-cola fails with following output:
Environment
git-cola
commit 90b70d2
OS
Ubuntu 14.04LTS x86 64bit
Python
2.7.5 from Ubuntu repo
Locale
zh_TW.UTF-8
The text was updated successfully, but these errors were encountered: