Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show in stash window doesn't work. #29

Closed
PyroBor opened this issue Oct 29, 2009 · 1 comment
Closed

Show in stash window doesn't work. #29

PyroBor opened this issue Oct 29, 2009 · 1 comment
Labels

Comments

@PyroBor
Copy link

PyroBor commented Oct 29, 2009

When choosing to show the diff of one particular stash. It doesn't do anything. I think i should show diff or something. And the output in the terminal is this:


Traceback (most recent call last):
  File "/usr/share/git-cola/lib/cola/qobserver.py", line 112, in SLOT
    self._callbacks[param](*args)
  File "/usr/share/git-cola/lib/cola/controllers/stash.py", line 101, in stash_show
    cola.notifier().broadcast(signals.diff_text, '%s\n\n%s' % (diffstat, diff))
NameError: global name 'signals' is not defined

This is with version 1.4.0

@davvid
Copy link
Member

davvid commented Oct 31, 2009

controllers.stash: Add missing cola.signals import

We forgot to import the signals module when this class during
the last round of refactoring.

Closed by ac662d24002a52348a86eb4d37eb426b94689ff2

Signed-off-by: David Aguilar davvid@gmail.com

davvid pushed a commit to davvid/git-cola that referenced this issue Jun 30, 2016
Use ci-helpers (from Astropy) for CI and enable AppVeyor
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants