Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git-cola didn't respect gui.encoding .gitconfig settings #303

Closed
Vdragon opened this issue Jun 14, 2014 · 0 comments
Closed

git-cola didn't respect gui.encoding .gitconfig settings #303

Vdragon opened this issue Jun 14, 2014 · 0 comments

Comments

@Vdragon
Copy link
Contributor

Vdragon commented Jun 14, 2014

according to git-config's manpage

gui.encoding

    Specifies the default encoding to use for displaying of file contents in git-gui(1) and gitk(1). It can be overridden by setting the encoding attribute for relevant files (see gitattributes(5)). If this option is not set, the tools default to the locale encoding.

git-cola should(?) treats file content as BIG5(CP950) by default on my system, however it displays UTF-8 encoded file correctly instead of BIG5 file:
20140614_001

It doesn't really matters me as I write all my files in UTF-8, though but ancient users will be affected(Windows store files using user's codepage settings by default.)
davvid added a commit that referenced this issue Jun 15, 2014
@davvid
gitcfg: honor gui.encoding when showing diffs
03d877c 
When no per-file attributes have been set via .gitattributes then we
should respect gui.encoding as the default file encoding.

This allows users to use non-utf-8 file content by setting the
gui.encoding variable, as is described in git-config(1).

Related-to: #303
Suggested-by: Reported-by: Ｖ字龍(Vdragon) <pika1021@gmail.com>
Signed-off-by: David Aguilar <davvid@gmail.com>
@davvid davvid closed this as completed in 81774fa Jun 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Vdragon