Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
git-cola failed to launch when source tree is under non-ASCII directory under Windows #305
Well, I was able to fix that error message based on the traceback, but I can't reproduce this one because I'm probably using utf-8 filesystem paths.
Do you know whether the filesystem paths are using a non-utf-8 encoding? I know Git itself has issues with non-utf-8 filesystem paths, and we do a lot of encoding/decoding of strings which forces us to require utf-8 for the filesystem itself.
We would need a way to get the filesystem encoding, it seems. I can try using os.getcwdu() instead of os.getcwd() as well, since that might help as well. Yep, unicode is hard ;-)
I added another tweak so that we avoid a decode()/encode() round trip when getting the repository path. Would you mind testing this again? There's a hope that this may have fixed this issue.
Unfortunately we may need to require utf-8 filesystem paths, but we'll see if this helps since it may make a difference. (crossing my fingers ;-))
pushed a commit
Jun 16, 2014
The filesystem itself(NTFS) probably using UTF-16 however I suspect that os.getcwdu() should be fine dealing with this without caring which encoding are used under the hood.