Text version of drag-and-dropped file does not work as expected

[nocnokneo]

Deficiencies compared to the way drag-and-drop works when dragging and dropping files from e.g. Nautilus file browser to a terminal window:

• the path is terminated by the newline which is very inconvenient for dropping into a terminal window (Nautilus appends a space)
• the path is not quoted
• dragging multiple files does not work

With Nautilus the dropped string looks like: '/path/to/file a' '/path/to/file b'

[davvid]

Interesting.. let me test a few things. The relevant code is in cola/qutils.py ~ line 798 def mimedata_from_paths.

We're using QMimeData.setUrls(list-of-QUrls), and we're definitely not adding the newlines internally. iTerm2 on mac osx handles the drop fine -- the files are separated by spaces and filenames with spaces come out as e.g. Foo\ Bar, which is at least shell-friendly.

I'll pushed up a version that uses both setText() and setUrls(). I'll test it using various Linux terminals. On iterm2, I had to comment-out the setUrls() line to start getting the text (which is quoted and space-separated via subprocess.list2cmdline()) to show up, as it seems that iterm2 handles the URLs in the mimedata...

Can you try that out and see if there's a difference between both text and urls being present, vs just text? What terminal are you using ~ could it be that its mimedata URL handling code is adding the newlines?

[davvid]

I did a bunch of testing on Linux and I learned quite a few things...

The key thing is the text/x-moz-list mime data. The tricky part is that several terminals (e.g. xfce4-terminal) will use the text/uri-list mime data, and ignore the x-moz-list.

gnome-terminal, on the other hand, uses text/x-moz-url when present, so we have to make sure that it contains valid data.

terminator breaks in almost all configurations, so I gave up on supporting it.

x-moz-list is automatically added by Qt, but it contains garbage, so we have to create it ourselves. Comparing against nautilus, there's a bunch of other keys (UTF8_STRING, etc) that are emitted, so I am adjusting git-cola to do the same.

[nocnokneo]

Awesome! git-cola keeps getting better and better!