Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Amend commit" feature accessibility(prev: Feature Request: Amend a commit) #640

Closed
timschumi opened this issue Jan 4, 2017 · 4 comments
Closed

"Amend commit" feature accessibility(prev: Feature Request: Amend a commit) #640

timschumi opened this issue Jan 4, 2017 · 4 comments

Comments

@timschumi
Copy link

timschumi commented Jan 4, 2017 •
edited
Loading

Please add the possibility to amend a commit.

If this feature already exists, then make it easier to access. At least I did not find it.
@davvid
Copy link
Member

davvid commented Jan 5, 2017

Ctrl+M (or Cmd+M on Mac OS) in the Commit Message Editor will switch to Amend mode.

There's also a checkbox in the Option drop-down sprocket menu next to the left of the Commit Summary input field.

@Vdragon
Copy link
Contributor

Vdragon commented Jan 5, 2017 •
edited
Loading

Refer screenshot, this feature is already implemented.
_086

Maybe we should move the feature to the "Commit" menu

@timschumi
Copy link
Author

Or like it's in git-gui (if we have enough free space for that). Just add in two radio buttons:

  1. New commit
  2. Amend commit

@davvid
Copy link
Member

davvid commented Jan 7, 2017

Thanks for the sug. I think we can add it to the Commit menu since that's a nice, logical place for it, and I suspect that others who go hunting for this behavior will be able to discover it there.

I'd prefer not to add extra radio buttons/UI elements for this since it's kinda ugly and we already have a more-convenient Ctrl+m hotkey for it.

@Vdragon Vdragon changed the title Feature Request: Amend a commit "Amend commit" feature accessibility(prev: Feature Request: Amend a commit) Jan 7, 2017
davvid added a commit to davvid/git-cola that referenced this issue Jan 24, 2017
@davvid
Merge branch 'amend-commit-menu-action'
92b522b 
Add "Amend Last Commit" to the "Commit" menu.

* amend-commit-menu-action:
  widgets: add "Amend Last Commit" to the "Commit" menu
  widgets: use a local alias for add_action_bool()
  doc: add Tim to the credits

Closes git-cola#640
Signed-off-by: David Aguilar <davvid@gmail.com>
@davvid davvid closed this as completed in c943ad1 Jan 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@davvid @Vdragon @timschumi