"Amend commit" feature accessibility(prev: Feature Request: Amend a commit) #640

Closed
timschumi opened this Issue Jan 4, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@timschumi

timschumi commented Jan 4, 2017

Please add the possibility to amend a commit.

If this feature already exists, then make it easier to access. At least I did not find it.

@davvid

This comment has been minimized.

Show comment
Hide comment
@davvid

davvid Jan 5, 2017

Member

Ctrl+M (or Cmd+M on Mac OS) in the Commit Message Editor will switch to Amend mode.

There's also a checkbox in the Option drop-down sprocket menu next to the left of the Commit Summary input field.

Member

davvid commented Jan 5, 2017

Ctrl+M (or Cmd+M on Mac OS) in the Commit Message Editor will switch to Amend mode.

There's also a checkbox in the Option drop-down sprocket menu next to the left of the Commit Summary input field.

@Vdragon

This comment has been minimized.

Show comment
Hide comment
@Vdragon

Vdragon Jan 5, 2017

Contributor

Refer screenshot, this feature is already implemented.
_086

Maybe we should move the feature to the "Commit" menu

Contributor

Vdragon commented Jan 5, 2017

Refer screenshot, this feature is already implemented.
_086

Maybe we should move the feature to the "Commit" menu

@timschumi

This comment has been minimized.

Show comment
Hide comment
@timschumi

timschumi Jan 5, 2017

Or like it's in git-gui (if we have enough free space for that). Just add in two radio buttons:

  1. New commit
  2. Amend commit

Or like it's in git-gui (if we have enough free space for that). Just add in two radio buttons:

  1. New commit
  2. Amend commit
@davvid

This comment has been minimized.

Show comment
Hide comment
@davvid

davvid Jan 7, 2017

Member

Thanks for the sug. I think we can add it to the Commit menu since that's a nice, logical place for it, and I suspect that others who go hunting for this behavior will be able to discover it there.

I'd prefer not to add extra radio buttons/UI elements for this since it's kinda ugly and we already have a more-convenient Ctrl+m hotkey for it.

Member

davvid commented Jan 7, 2017

Thanks for the sug. I think we can add it to the Commit menu since that's a nice, logical place for it, and I suspect that others who go hunting for this behavior will be able to discover it there.

I'd prefer not to add extra radio buttons/UI elements for this since it's kinda ugly and we already have a more-convenient Ctrl+m hotkey for it.

@Vdragon Vdragon changed the title from Feature Request: Amend a commit to "Amend commit" feature accessibility(prev: Feature Request: Amend a commit) Jan 7, 2017

davvid added a commit to davvid/git-cola that referenced this issue Jan 24, 2017

Merge branch 'amend-commit-menu-action'
Add "Amend Last Commit" to the "Commit" menu.

* amend-commit-menu-action:
  widgets: add "Amend Last Commit" to the "Commit" menu
  widgets: use a local alias for add_action_bool()
  doc: add Tim to the credits

Closes #640
Signed-off-by: David Aguilar <davvid@gmail.com>

@davvid davvid closed this in c943ad1 Jan 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment