New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After window maximisation, git-cola hangs with no display. #641

Closed
Parashurama opened this Issue Jan 5, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@Parashurama

Parashurama commented Jan 5, 2017

As title said, I am unable to use git-cola, if gui_state.mainview.maximized is true in .config/git-cola/settings with latest master.
The program launch just fine, but hang with no visible window.
Also deleting settings file restore default settings, but the problem comes back as soon I quit the window and relaunch.

After git bisecting, I think I found the problem in 5b7b85a.
Any commit before works fine for me.

OS: Lubuntu 16.04 64bits

@Parashurama Parashurama changed the title from After window maximisation, git-cola won't relaunch. to After window maximisation, git-cola hangs with no display. Jan 5, 2017

@Coacher

This comment has been minimized.

Show comment
Hide comment
@Coacher

Coacher Jan 6, 2017

Contributor

So this is what causing these hangs! @Parashurama, thank you very much for getting to the bottom of this. I can also confirm this behaviour with python-2.7 or python-3.4 and the current master @ e38a026. OS Gentoo amd64.

Steps to reproduce:

  1. Wipe ~/.config/git-cola directory.
  2. cd into any git-repo
  3. Execute git-cola (git-cola window opens as usual).
  4. Maximize window and close git-cola.
  5. Execute git-cola again.

Expected results:
git-cola window opens again.

Actual results:
git-cola window doesn't appear. No errors are printed in terminal. In terminal I see $ git-cola indefinitely. Nothing related in ~/.xsession-errors.

Please fix, this is very annoying.

Contributor

Coacher commented Jan 6, 2017

So this is what causing these hangs! @Parashurama, thank you very much for getting to the bottom of this. I can also confirm this behaviour with python-2.7 or python-3.4 and the current master @ e38a026. OS Gentoo amd64.

Steps to reproduce:

  1. Wipe ~/.config/git-cola directory.
  2. cd into any git-repo
  3. Execute git-cola (git-cola window opens as usual).
  4. Maximize window and close git-cola.
  5. Execute git-cola again.

Expected results:
git-cola window opens again.

Actual results:
git-cola window doesn't appear. No errors are printed in terminal. In terminal I see $ git-cola indefinitely. Nothing related in ~/.xsession-errors.

Please fix, this is very annoying.

@davvid

This comment has been minimized.

Show comment
Hide comment
@davvid

davvid Jan 7, 2017

Member

I'm picking this up now, thanks for the heads-up.

The changes that were made for handling the maximization was implemented by a Windows tester, so I suspect that we can make it behave correctly by special-casing Windows to use the current code path and then let the rest (Linux, Mac OS) use the older code path, which did not have this problem.

I wonder if I should special-case both Windows and Mac OS, and only restore the old code path for Linux? I'm going to go down that route for now unless we hear from Mac OS users that are also experiencing this issue until I have some time to test it on Mac OS as well.

The next release will not be tagged until this issue is fixed.

Member

davvid commented Jan 7, 2017

I'm picking this up now, thanks for the heads-up.

The changes that were made for handling the maximization was implemented by a Windows tester, so I suspect that we can make it behave correctly by special-casing Windows to use the current code path and then let the rest (Linux, Mac OS) use the older code path, which did not have this problem.

I wonder if I should special-case both Windows and Mac OS, and only restore the old code path for Linux? I'm going to go down that route for now unless we hear from Mac OS users that are also experiencing this issue until I have some time to test it on Mac OS as well.

The next release will not be tagged until this issue is fixed.

@davvid davvid closed this in d241c09 Jan 7, 2017

davvid added a commit that referenced this issue Jan 7, 2017

Merge branch 'fullscreen-settings'
* fullscreen-settings:
  widgets: fix maximized window restoration on Linux
  doc: update v2.10 release notes draft

Closes #641
Signed-off-by: David Aguilar <davvid@gmail.com>
@Coacher

This comment has been minimized.

Show comment
Hide comment
@Coacher

Coacher Jan 7, 2017

Contributor

I can confirm this is no longer reproducible with the current master @ 4d76169.
Thank you for the fix!

Contributor

Coacher commented Jan 7, 2017

I can confirm this is no longer reproducible with the current master @ 4d76169.
Thank you for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment