-
-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
After window maximisation, git-cola hangs with no display. #641
Comments
So this is what causing these hangs! @Parashurama, thank you very much for getting to the bottom of this. I can also confirm this behaviour with python-2.7 or python-3.4 and the current master @ e38a026. OS Gentoo amd64. Steps to reproduce:
Expected results: Actual results: Please fix, this is very annoying. |
I'm picking this up now, thanks for the heads-up. The changes that were made for handling the maximization was implemented by a Windows tester, so I suspect that we can make it behave correctly by special-casing Windows to use the current code path and then let the rest (Linux, Mac OS) use the older code path, which did not have this problem. I wonder if I should special-case both Windows and Mac OS, and only restore the old code path for Linux? I'm going to go down that route for now unless we hear from Mac OS users that are also experiencing this issue until I have some time to test it on Mac OS as well. The next release will not be tagged until this issue is fixed. |
* fullscreen-settings: widgets: fix maximized window restoration on Linux doc: update v2.10 release notes draft Closes #641 Signed-off-by: David Aguilar <davvid@gmail.com>
I can confirm this is no longer reproducible with the current master @ 4d76169. |
As title said, I am unable to use git-cola, if gui_state.mainview.maximized is true in .config/git-cola/settings with latest master.
The program launch just fine, but hang with no visible window.
Also deleting settings file restore default settings, but the problem comes back as soon I quit the window and relaunch.
After git bisecting, I think I found the problem in 5b7b85a.
Any commit before works fine for me.
OS: Lubuntu 16.04 64bits
The text was updated successfully, but these errors were encountered: