Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
After window maximisation, git-cola hangs with no display. #641
As title said, I am unable to use git-cola, if gui_state.mainview.maximized is true in .config/git-cola/settings with latest master.
After git bisecting, I think I found the problem in 5b7b85a.
OS: Lubuntu 16.04 64bits
So this is what causing these hangs! @Parashurama, thank you very much for getting to the bottom of this. I can also confirm this behaviour with python-2.7 or python-3.4 and the current master @ e38a026. OS Gentoo amd64.
Steps to reproduce:
Please fix, this is very annoying.
I'm picking this up now, thanks for the heads-up.
The changes that were made for handling the maximization was implemented by a Windows tester, so I suspect that we can make it behave correctly by special-casing Windows to use the current code path and then let the rest (Linux, Mac OS) use the older code path, which did not have this problem.
I wonder if I should special-case both Windows and Mac OS, and only restore the old code path for Linux? I'm going to go down that route for now unless we hear from Mac OS users that are also experiencing this issue until I have some time to test it on Mac OS as well.
The next release will not be tagged until this issue is fixed.