New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centos 6.8 Qt issue #692

Closed
eephillip opened this Issue May 2, 2017 · 5 comments

Comments

Projects
None yet
2 participants
@eephillip

eephillip commented May 2, 2017

Version 2.6 works, but upgrading past that I get the following error.
Using the system python 2.6.6
PyQt4.x86_64 4.6.2-9.el6 @base
PyQt4-devel.x86_64 4.6.2-9.el6 @base

Traceback (most recent call last):
  File "/home/user/.local/bin/git-cola", line 53, in <module>
    from cola.main import main  # pylint: disable=wrong-import-position
  File "/home/user/.local/git-cola/git-cola-2.10/cola/main.py", line 9, in <module>
    from .app import add_common_arguments
  File "/home/user/.local/git-cola/git-cola-2.10/cola/app.py", line 23, in <module>
    from qtpy import QtWidgets
  File "/home/user/.local/git-cola/git-cola-2.10/qtpy/QtWidgets.py", line 32, in <module>
    QFontMetricsF, QGlyphRun, QGradient, QHelpEvent, QHideEvent,
NameError: name 'QGlyphRun' is not defined
@davvid

This comment has been minimized.

Show comment
Hide comment
@davvid

davvid May 3, 2017

Member

this might be as simple as updating our vendored copy of qtpy.

Member

davvid commented May 3, 2017

this might be as simple as updating our vendored copy of qtpy.

@eephillip

This comment has been minimized.

Show comment
Hide comment
@eephillip

eephillip May 4, 2017

Is that something I could patch just to try it out?

eephillip commented May 4, 2017

Is that something I could patch just to try it out?

@davvid

This comment has been minimized.

Show comment
Hide comment
@davvid

davvid May 4, 2017

Member

A quick workaround is to remove QGlyphRun, from that file. We don't use that symbol so we don't need it there.

The long-term solution is to report this problem at https://github.com/spyder-ide/qtpy

I tested this on PyQt4 4.6 with the latest qtpy and it has this same problem.

Member

davvid commented May 4, 2017

A quick workaround is to remove QGlyphRun, from that file. We don't use that symbol so we don't need it there.

The long-term solution is to report this problem at https://github.com/spyder-ide/qtpy

I tested this on PyQt4 4.6 with the latest qtpy and it has this same problem.

@davvid

This comment has been minimized.

Show comment
Hide comment
@davvid

davvid May 4, 2017

Member

Another alternative is to build a newer PyQt from source. PyQt 4.9 should work with that vintage. I didn't realize that we may have silently updated our pyqt requirements when we moved to qtpy so I'll probably be patching this into our copy soon.

Member

davvid commented May 4, 2017

Another alternative is to build a newer PyQt from source. PyQt 4.9 should work with that vintage. I didn't realize that we may have silently updated our pyqt requirements when we moved to qtpy so I'll probably be patching this into our copy soon.

davvid added a commit to davvid/git-cola that referenced this issue May 4, 2017

Merge branch 'qtpy-pyqt46'
* qtpy-pyqt46:
  qtpy: add support for PyQt 4.6

Closes git-cola#692
Signed-off-by: David Aguilar <davvid@gmail.com>

@davvid davvid closed this in c44881c May 4, 2017

@eephillip

This comment has been minimized.

Show comment
Hide comment
@eephillip

eephillip May 5, 2017

Just pulled in merge spyder-ide/qtpy#106 into v2.10. Working great, thanks for supporting.

eephillip commented May 5, 2017

Just pulled in merge spyder-ide/qtpy#106 into v2.10. Working great, thanks for supporting.

davvid added a commit to davvid/git-cola that referenced this issue May 6, 2017

qtpy: update spider-ide/qtpy
Update to spider-ide/qtpy@8cb3528cab23d773b5a160f4a9dd603ad229368a.
This updates the PyQt 4.6 compatibility to the better version that
ended up being merged into qtpy, and brings in other improvements
from qtpy up until now.  We'll update to qtpy/v1.3.0 when released.

Related-to: git-cola#692
Signed-off-by: David Aguilar <davvid@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment