New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`cola.inotify` config in repo local config is not honored when Git Cola is launched from desktop entry(repo selection window) #695

Closed
Vdragon opened this Issue May 9, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@Vdragon
Contributor

Vdragon commented May 9, 2017

Bug Reproducing Instructions

  1. git config --local cola.inotify false a non-empty git repository(repository with no commits will not trigger the issue)
  2. Launch Git Cola from desktop entry, open the repository
  3. Create new file in work tree

Current Behavior

"new file" automatically listed in status widget even when cola.inotify is false and the focus is not returned to Git Cola window

Expected Behavior

"new file" is not automatically listed in status widget until focus is back to Git Cola's window

@Vdragon Vdragon changed the title from `cola.inotify` config in repo local config is not honored when Git Cola is launched from `--prompt` to `cola.inotify` config in repo local config is not honored when Git Cola is launched from desktop entry(repo selection window) May 10, 2017

@Vdragon Vdragon added the bug label May 10, 2017

davvid added a commit to davvid/git-cola that referenced this issue Oct 19, 2017

doc/relnotes/v3.0: update release notes draft for git-cola#695
Signed-off-by: David Aguilar <davvid@gmail.com>

davvid added a commit to davvid/git-cola that referenced this issue Oct 19, 2017

Merge branch 'inotify'
Honor `cola.inotify` in a repo-local configuration when launched
via `git cola --prompt`.

* inotify:
  doc/relnotes/v3.0: update release notes draft for git-cola#695
  app: refactor to defer creation of the fsmonitor

Closes git-cola#695
Reported-by: V字龍 <Vdragon.Taiwan@gmail.com>
Signed-off-by: David Aguilar <davvid@gmail.com>

@davvid davvid closed this in d6f0fc1 Oct 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment