Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to increase the amount of recent repositories? #752

Closed
ebousse opened this issue Nov 17, 2017 · 3 comments
Closed

Option to increase the amount of recent repositories? #752

ebousse opened this issue Nov 17, 2017 · 3 comments

Comments

@ebousse
Copy link

ebousse commented Nov 17, 2017

At the moment, it seems that git-cola only shows the latest 6 or 7 repositories when opening up. However, it might happen to work with ~10 repositories, which then requires using the "Select manually" option to choose repositories that have been pushed out of the list.

Could we imagine an option to choose in the preferences the amount of recent repositories we want git-cola to remember, and hence to show up in the start window?

Note: I know that "favorites" can be used, but when git-cola opens up it only shows the recent repositories, not the favorites. Maybe yet another feature could be to show the favorites in the opening window.

@ebousse
Copy link
Author

ebousse commented Nov 17, 2017

I guess the culprit is this line? :) https://github.com/git-cola/git-cola/blob/master/cola/settings.py#L128

@davvid
Copy link
Member

davvid commented Nov 22, 2017

Yes, that's the culprit. We should make that configurable via cola.maxrecent, and default it to 10.

Using gitcfg.current().get('cola.maxrecent', 10) instead of the hard-coded 8 can implement that feature after importing gitcfg. Updating the documentation should be the bulk of the diff.

davvid added a commit to davvid/git-cola that referenced this issue Nov 22, 2017
Related-to: git-cola#752
Signed-off-by: David Aguilar <davvid@gmail.com>
davvid added a commit to davvid/git-cola that referenced this issue Nov 22, 2017
Related-to: git-cola#752
Signed-off-by: David Aguilar <davvid@gmail.com>
davvid added a commit to davvid/git-cola that referenced this issue Nov 22, 2017
Allow `cola.maxrecent` to control the number of repositories shown in
the startup window and "Recent Repositories" menu.

Related-to: git-cola#752
Signed-off-by: David Aguilar <davvid@gmail.com>
davvid added a commit to davvid/git-cola that referenced this issue Nov 22, 2017
In preparation for adding the `maxrecent` field.

Related-to: git-cola#752
Signed-off-by: David Aguilar <davvid@gmail.com>
davvid added a commit to davvid/git-cola that referenced this issue Nov 22, 2017
Add the recent repositories configuration to the preferences window.

Related-to: git-cola#752
Signed-off-by: David Aguilar <davvid@gmail.com>
@davvid davvid closed this as completed in 4298ad9 Nov 22, 2017
@ebousse
Copy link
Author

ebousse commented Nov 22, 2017

I've just tested the master branch and it works just fine! thanks :)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants