Unable to launch editor when PATH env. var. cantains non-ASCII characters

[brlin-tw]

Reproducing Instruction

1. Run env PATH="工:$PATH" git cola in a Git repository in a terminal
2. Select a file in status widget
3. Select "Launch editor" option in the contextual menu

Expected Behavior

Editor launched without errors

Current Behavior

Editor not launched with the following error:

Traceback

Traceback (most recent call last):

  File "/home/Lin-Buo-Ren/.local/share/git-cola/lib/cola/cmds.py", line 1231, in do
    core.fork(utils.shell_split(editor) + opts)

  File "/home/Lin-Buo-Ren/.local/share/git-cola/lib/cola/decorators.py", line 23, in _caller
    return caller(f, *args, **opts)

  File "/home/Lin-Buo-Ren/.local/share/git-cola/lib/cola/decorators.py", line 75, in interruptable
    result = func(*args, **opts)

  File "/home/Lin-Buo-Ren/.local/share/git-cola/lib/cola/core.py", line 260, in _fork_posix
    return subprocess.Popen(encoded_args, cwd=cwd).pid

  File "/usr/lib/python2.7/subprocess.py", line 711, in __init__
    errread, errwrite)

  File "/usr/lib/python2.7/subprocess.py", line 1343, in _execute_child
    raise child_exception

UnicodeDecodeError: 'ascii' codec can't decode byte 0xe5 in position 0: ordinal not in range(128)

Traceback (Original)

  File "/usr/local/share/git-cola/lib/cola/cmds.py", line 2365, in do
    return cmd.do()

  File "/usr/local/share/git-cola/lib/cola/cmds.py", line 1194, in do
    details = core.decode(e.strerror)

AttributeError: 'exceptions.UnicodeDecodeError' object has no attribute 'strerror'

git config

gui.editor=kate --startanon
gui.historybrowser=gitk
cola.boldheaders=true
cola.tabwidth=4
cola.linebreak=false
cola.spellcheck=false
cola.fontdiff=Noto Sans Mono CJK TC,11,-1,5,50,0,0,0,0,0
cola.showpath=false

[davvid]

Python2 or Python3?

[davvid]

I pushed up a commit which should fix this traceback and give us more details about what's going on. Please let me know what it's reporting now.

It's curious that we got a UnicodeDecode error. Are the filenames ascii, or non-utf8?

[brlin-tw]

Python2 or Python3?

Python 2, and to be specific:

Git Cola version 3.0 (v3.0-217-ga1f4867c)

-   Linux-4.13.0-38-generic-x86_64-with-neon-16.04-xenial
-   Python (/usr/bin/python) 2.7.12 (default, Dec 4 2017, 14:50:18) \[GCC 5.4.0 20160609\]
-   Git 2.17.0
-   Qt 5.10.0
-   QtPy 1.3.1
-   PyQt5 5.9.2

Are the filenames ascii, or non-utf8?

The filename to be editted is in ASCII AFAICT

Please let me know what it's reporting now.

Cannot exec "kate --startanon": please configure your editor

Traceback (most recent call last):

  File "/usr/local/share/git-cola/lib/cola/cmds.py", line 1190, in do
    core.fork(utils.shell_split(editor) + opts)

  File "/usr/local/share/git-cola/lib/cola/decorators.py", line 23, in _caller
    return caller(f, *args, **opts)

  File "/usr/local/share/git-cola/lib/cola/decorators.py", line 75, in interruptable
    result = func(*args, **opts)

  File "/usr/local/share/git-cola/lib/cola/core.py", line 260, in _fork_posix
    return subprocess.Popen(encoded_args, cwd=cwd).pid

  File "/usr/lib/python2.7/subprocess.py", line 711, in __init__
    errread, errwrite)

  File "/usr/lib/python2.7/subprocess.py", line 1343, in _execute_child
    raise child_exception

UnicodeDecodeError: 'ascii' codec can't decode byte 0xe8 in position 18: ordinal not in range(128)

[davvid]

Hmm byte 0xe8 is è is it possible that the filename starts with that unicode character? Your editor, kate --startanon is 16 characters long, so position 18 should be the very first character of the filename since there's a space before that at position 17.

This is pretty weird because we handle utf-8 encoded filenames just fine. Do you happen to have a repo that you can post somewhere that can demonstrate the problem?

[brlin-tw]

Your editor, kate --startanon is 16 characters long, so position 18 should be the very first character of the filename since there's a space before that at position 17.

My guess is it has to do with my PATH configuration: /home/Lin-Buo-Ren/工作空間/第三方專案/vdent - Verilog Indenter - Simple indent program for Verilog source code. Trims end of line white space and indents lines based on nested depth of code blocks/bin:/home/Lin-Buo-Ren/.cargo/bin:/home/Lin-Buo-Ren/.gem/ruby/2.3.0/bin:/home/Lin-Buo-Ren/工作空間/第三方專案/iStyle - Fast and Free Automatic Formatter for Verilog Source Code/bin/release:/home/Lin-Buo-Ren/.cabal/bin:/home/Lin-Buo-Ren/軟體/BFG Repo-Cleaner:/home/Lin-Buo-Ren/bin:/home/Lin-Buo-Ren/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin, which the 18th character is '工' (0xe5, 0xb7, 0xa5).

I've reset the PATH environmental variable and the editor successfully launched.