Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Git Cola silently fails when Git for Windows is not installed #830

Closed
brlin-tw opened this issue May 27, 2018 · 0 comments
Closed

Git Cola silently fails when Git for Windows is not installed #830

brlin-tw opened this issue May 27, 2018 · 0 comments

Comments

@brlin-tw
Copy link
Contributor

brlin-tw commented May 27, 2018 •
edited
Loading

I remembered to install Python 3.6 but forgot to install Git, when launching Git Cola from the Start Menu nothing happened until I recognized something is missing.

A simple error message to indicate that a Git installation can't be found in the setup program or at launch would be helpful.

NOTE: I do have a GitHub Desktop installation, but it doesn't seem to be enough.
davvid added a commit to davvid/git-cola that referenced this issue Jun 1, 2018
@davvid
git: refactor Git.git() to not raise when git cannot be found
c313bde 
We not return a non-zero exit code and a stderr message.  Higher-level
code will take this and detect when git is unavailable.

Related-to: git-cola#830
Signed-off-by: David Aguilar <davvid@gmail.com>
@davvid davvid closed this as completed in 05d8cbd Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brlin-tw