recent: update recent repo list when opening repo #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the recent repo list is only updated when the application is exited, due to the list being stored in the settings, which are saved on exit. As well as newly opened repos not showing on the recent list, it means that if you start on repo A, open repo B, then open repo C, and finally exit, repo B will not have been added to the recent list. With this change, when a repo is opened it will be added to the recent list immediately, and will therefore show in the recent repo list in the menu. In addition to that, a signal was created for the changing of the worktree, so that the bookmarks widget for the recent repo list can be updated. Closes #937 Signed-off-by: Tim Brown stimut@gmail.com
|
I'm open to feedback on where the best place to put the functionality is. In particular, where the code should go that saves the newly opened repo to the recent list. I put it in |
davvid
added a commit
that referenced
this pull request
Oct 26, 2019
…s list Signed-off-by: David Aguilar <davvid@gmail.com>
davvid
added a commit
that referenced
this pull request
Oct 26, 2019
* stimut/add-to-recent-on-open: recent: update recent repo list when opening repo Signed-off-by: David Aguilar <davvid@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the recent repo list is only updated when the application is
exited, due to the list being stored in the settings, which are saved on
exit. As well as newly opened repos not showing on the recent list, it
means that if you start on repo A, open repo B, then open repo C, and
finally exit, repo B will not have been added to the recent list.
With this change, when a repo is opened it will be added to the recent
list immediately, and will therefore show in the recent repo list in the
menu. In addition to that, a signal was created for the changing of the
worktree, so that the bookmarks widget for the recent repo list can be
updated.
Closes #937
Signed-off-by: Tim Brown stimut@gmail.com