editremotes: select newly added remote #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously after added a new remote, we would either reselect the previously selected remote, or select the first remote in the list. Since newly added remotes get added to the end of the list, the new remote was therefore never selected. This change makes the newly added remote selected in the list. Closes #875 Signed-off-by: Tim Brown stimut@gmail.com
davvid
added a commit
that referenced
this pull request
Oct 26, 2019
…mote * stimut/update-selected-on-new-delete-remote: editremotes: select newly added remote Signed-off-by: David Aguilar <davvid@gmail.com>
davvid
added a commit
that referenced
this pull request
Oct 26, 2019
Signed-off-by: David Aguilar <davvid@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously after added a new remote, we would either reselect the
previously selected remote, or select the first remote in the list.
Since newly added remotes get added to the end of the list, the new
remote was therefore never selected.
This change makes the newly added remote selected in the list.
Closes #875
Signed-off-by: Tim Brown stimut@gmail.com