settings: fix issue with Recent repository count #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Recent repository count setting did not work as expected due to an off-by-one error. If the setting was set to 4 for instance, then git-cola would keep track of the last 3 repositories (meaning the settings file would have the information on 3 repositories, one of which is the currently opened repository). This was because a nonstrict inequality was used instead of a strict inequality during a check. With this fix, the settings file correctly now correctly keeps track of the last 4 repositories. Signed-off-by: Victor Gambier victor.gambier@imt-atlantique.net
davvid
added a commit
that referenced
this pull request
Dec 12, 2019
* VeganHunter/secondcommit: settings: fix issue with Recent repository count Signed-off-by: David Aguilar <davvid@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Recent repository count setting did not work as expected due to an off-by-one error.
If the setting was set to 4 for instance, then git-cola would keep track of the last 3 repositories (meaning the settings file would have the information on 3 repositories, one of which is the currently opened repository). This was because a nonstrict inequality was used instead of a strict inequality during a check.
With this fix, the settings file correctly now correctly keeps track of the last 4 repositories.
Signed-off-by: Victor Gambier victor.gambier@imt-atlantique.net