New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: Fixed i18n_test by setting the LANGUAGE env variable #231

Merged
merged 1 commit into from Feb 17, 2014

Conversation

Projects
None yet
2 participants
@hsoft
Member

hsoft commented Feb 16, 2014

When I ran i18n_test, I had failures on 'ja_JP' and 'de_DE' tests. After
a little search, it turns out that gettext was unable to find the proper
mo files. cola's approach to setting up its translation is to set
environement variables and then call translation() without a
languages argument.

Before this patch, the environment variables we set were "LANG" and
"LC_MESSAGES". However, this is what Python doc for find() says:

"""
If languages is not given, then the following environment variables are
searched: LANGUAGE, LC_ALL, LC_MESSAGES, and LANG. The first one
returning a non-empty value is used for the languages variable.
"""

Therefore, non-empty "LANGUAGE" or "LC_ALL" env variables would
mess up our translation.

I've added a line setting "LANGUAGE" (in addition to the two others
already there) and it fixed the tests for me.

Signed-off-by: Virgil Dupras hsoft@hardcoded.net

i18n: Fixed i18n_test by setting the LANGUAGE env variable
When I ran i18n_test, I had failures on 'ja_JP' and 'de_DE' tests. After
a little search, it turns out that gettext was unable to find the proper
mo files. cola's approach to setting up its translation is to set
environement variables and then call `translation()` without a
`languages` argument.

Before this patch, the environment variables we set were "LANG" and
"LC_MESSAGES". However, this is what Python doc for `find()` says:

"""
If languages is not given, then the following environment variables are
searched: LANGUAGE, LC_ALL, LC_MESSAGES, and LANG. The first one
returning a non-empty value is used for the languages variable.
"""

Therefore, non-empty "LANGUAGE" or "LC_ALL" env variables would
mess up our translation.

I've added a line setting "LANGUAGE" (in addition to the two others
already there) and it fixed the tests for me.

Signed-off-by: Virgil Dupras <hsoft@hardcoded.net>
@davvid

This comment has been minimized.

Show comment
Hide comment
@davvid

davvid Feb 17, 2014

Member

Thanks!

Member

davvid commented Feb 17, 2014

Thanks!

davvid added a commit that referenced this pull request Feb 17, 2014

Merge pull request #231 from hsoft/fix-i18n
i18n: fix i18n test by setting the LANGUAGE env variable

Signed-off-by: David Aguilar <davvid@gmail.com>

@davvid davvid merged commit 2044e3f into git-cola:master Feb 17, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment