i18n: Fixed i18n_test by setting the LANGUAGE env variable #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I ran i18n_test, I had failures on 'ja_JP' and 'de_DE' tests. After a little search, it turns out that gettext was unable to find the proper mo files. cola's approach to setting up its translation is to set environement variables and then call `translation()` without a `languages` argument. Before this patch, the environment variables we set were "LANG" and "LC_MESSAGES". However, this is what Python doc for `find()` says: """ If languages is not given, then the following environment variables are searched: LANGUAGE, LC_ALL, LC_MESSAGES, and LANG. The first one returning a non-empty value is used for the languages variable. """ Therefore, non-empty "LANGUAGE" or "LC_ALL" env variables would mess up our translation. I've added a line setting "LANGUAGE" (in addition to the two others already there) and it fixed the tests for me. Signed-off-by: Virgil Dupras <hsoft@hardcoded.net>
|
Thanks! |
davvid
added a commit
that referenced
this pull request
Feb 17, 2014
i18n: fix i18n test by setting the LANGUAGE env variable Signed-off-by: David Aguilar <davvid@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I ran i18n_test, I had failures on 'ja_JP' and 'de_DE' tests. After
a little search, it turns out that gettext was unable to find the proper
mo files. cola's approach to setting up its translation is to set
environement variables and then call
translation()without alanguagesargument.Before this patch, the environment variables we set were "LANG" and
"LC_MESSAGES". However, this is what Python doc for
find()says:"""
If languages is not given, then the following environment variables are
searched: LANGUAGE, LC_ALL, LC_MESSAGES, and LANG. The first one
returning a non-empty value is used for the languages variable.
"""
Therefore, non-empty "LANGUAGE" or "LC_ALL" env variables would
mess up our translation.
I've added a line setting "LANGUAGE" (in addition to the two others
already there) and it fixed the tests for me.
Signed-off-by: Virgil Dupras hsoft@hardcoded.net