Improve fork() on Windows. #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Windows implementation of fork(), _fork_win32(), had some code to try to allow commands like gitk to be executed. However, this code did not work for multiple reasons. The main issue is that on Windows, gitk is actually provided by a batch file named gitk.cmd. If the first element in the args list passed to subprocess.Popen() is simply "gitk", the file won't be found and the command will fail. This could be solved by passing shell=True to Popen(), but that is not ideal. The fix provided here is to implement the same path searching algorithm that the Windows shell uses to locate an executable, taking into account the PATHEXT environment variable, and to use the result of that search as the first element of the args list for subprocess.Popen(). Signed-off-by: Daniel Harding <dharding@living180.net>
davvid
added a commit
that referenced
this pull request
May 9, 2014
Improve fork() on Windows. Signed-off-by: David Aguilar <davvid@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Windows implementation of
fork(),_fork_win32(), had some code to try to allow commands like gitk to be executed. However, this code did not work for multiple reasons. The main issue is that on Windows, gitk is actually provided by a batch file named gitk.cmd. If the first element in theargslist passed tosubprocess.Popen()is simply"gitk", the file won't be found and the command will fail. This could be solved by passingshell=TruetoPopen(), but that is not ideal. The fix provided here is to implement the same path searching algorithm that the Windows shell uses to locate an executable, taking into account thePATHEXTenvironment variable, and to use the result of that search as the first element of theargslist forsubprocess.Popen().