Fix stdout()/stderr() helpers for Python 3 #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Python 3, the core.stdout() and core.stderr() helper functions were attempting to concatenate the message encoded as a bytestring with a unicode string containing a newline, which raises a TypeError. Fix this by concatenating the newline first, and then only encoding the result if on Python 2, since Python 3 wants unicode strings anyway. Signed-off-by: Daniel Harding <dharding@living180.net>
|
What about a simpler solution like |
That doesn't work on Python 3, because in that case |
|
Oh yeah, true. So the source of the error isn't only the concatenation. |
|
Right. The first solution I tried was |
davvid
added a commit
that referenced
this pull request
May 9, 2014
Fix stdout()/stderr() helpers for Python 3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Python 3, the
core.stdout()andcore.stderr()helper functions were attempting to concatenate the message encoded as a bytestring with a unicode string containing a newline, which raises aTypeError. Fix this by concatenating the newline first, and then only encoding the result if on Python 2, since Python 3 wants unicode strings anyway.