tag: Display error message when creating tag with invalid name (fix issue: #286) #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an invalid name is supplied during tag creation, there was no error displayed to the user. It would always say "Created a new tag named [tag name]" even though no tag is actually created. This change will display error message instead of tag creation message when git tag command fails. Reported-by: Ｖ字龍(Vdragon) <pika1021@gmail.com> Signed-off-by: Minarto Margoliono <lie.r.min.g@gmail.com>
The error message was displayed using information dialog. As a result, it is displaying git-cola icon instead of error icon. This change use the proper error dialog instead of information dialog. Reported-by: Ｖ字龍(Vdragon) <pika1021@gmail.com> Signed-off-by: Minarto Margoliono <lie.r.min.g@gmail.com>
The error message was handled in cmds.py while the success code was handled in createtag.py. This will make it harder to maintain later. This change move the error handling code to the same location as success handling code. Reported-by: Ｖ字龍(Vdragon) <pika1021@gmail.com> Signed-off-by: Minarto Margoliono <lie.r.min.g@gmail.com>
davvid
added a commit
that referenced
this pull request
Jun 14, 2014
tag: Display error message when creating tag with invalid name Closes #286 Signed-off-by: David Aguilar <davvid@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an invalid name is supplied during tag creation, there was no error
displayed to the user. It would always say "Created a new tag named [tag
name]" even though no tag is actually created.
This change will display error message instead of tag creation message
when git tag command fails.
Reported-by: Ｖ字龍(Vdragon) pika1021@gmail.com
Signed-off-by: Minarto Margoliono lie.r.min.g@gmail.com