Fixes for inotify use #393

Merged
merged 2 commits into from Dec 15, 2014

Conversation

Projects
None yet
2 participants
@takluyver
Contributor

takluyver commented Dec 14, 2014

  • On Python 3, pyinotify takes unicode paths, not bytes. Annoyingly, it skips over non-unicode paths without throwing a clear error, so it took a bit of digging to find the problem.
  • The _is_pyinotify_08x() method is really interested in 0.8 or above, but was testing just for 0.8.x. We're on 0.9.x now, so I updated it to treat that like 0.8. It looks like pyinotify 0.8 was released more than 5 years ago, so maybe we should just remove this check altogether and assume we have a new enough version.

davvid added a commit that referenced this pull request Dec 15, 2014

Merge pull request #393 from takluyver/inotify-fixing
python3: inotify fixes

Signed-off-by: David Aguilar <davvid@gmail.com>

@davvid davvid merged commit d605516 into git-cola:master Dec 15, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment