Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Ctrl+O as shortcut for opening Git repository #507

Merged
merged 1 commit into from
Oct 12, 2015

Conversation

AndiDog
Copy link
Contributor

@AndiDog AndiDog commented Oct 5, 2015

No description provided.

Signed-off-by: Andreas Sommer <andreas.sommer87@googlemail.com>
@davvid
Copy link
Member

davvid commented Oct 12, 2015

Thanks. I'd like to merge this but I vaguely recall that Ctrl-O is the platform-specific hotkey for opening the preferences page on Mac OS X. I may be mis-remembering, though, so I'll double check now before merging.

UPDATE: just checked, we're in the clear. I think "Open" is more common than tweaking preferences, so if we run into a conflict down the road then we'll prefer this one.

davvid added a commit that referenced this pull request Oct 12, 2015
main: use Ctrl+O as shortcut for opening Git repository

Signed-off-by: David Aguilar <davvid@gmail.com>
@davvid davvid merged commit a29f6ec into git-cola:master Oct 12, 2015
@AndiDog
Copy link
Contributor Author

AndiDog commented Oct 12, 2015

I think I also checked before (in code only, don't have a Mac) that there are no conflicts. Typically Cmd+O is "Open file" and Cmd+"," is for app preferences, if I remember correctly from my Mac experience.

Thanks for merging!

@AndiDog AndiDog deleted the feature/open-repo-shortcut branch October 12, 2015 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants