Change DAG layout technique #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Efimov Vasily <real@ispras.ru>
Current commit layout algorithm returns bad looking graph in several sophisticated configurations. Defects could be found near commits a049169 2462221 of Git Cola graph. The ambiguous edge overlapping may confuse a user. The new algorithm is free of this defects. No other defects were found in Git Cola graph too. While overall appearance still could be improved there are no confusing configuration noticed. The layout technique description is presented by comments in the code. Signed-off-by: Efimov Vasily <real@ispras.ru>
Signed-off-by: Efimov Vasily <real@ispras.ru>
Signed-off-by: Efimov Vasily <real@ispras.ru>
|
This sounds like a great idea. I was vaguely aware that there were some configurations that could lead to issues, but didn't have a chance to look into it. I'll test this and get it merged in time for the next release. cheers! |
davvid
added a commit
that referenced
this pull request
Jan 18, 2017
* laerreal/new_layout: dag: remove useless 'nodes' argument of 'layout_commits' method dag: remove useless 'nodes' argument of 'position_nodes' method dag: change commit nodes layout algorithm dag: add 'column' field to Commit Signed-off-by: David Aguilar <davvid@gmail.com>
davvid
reviewed
Jan 18, 2017
|
|
||
| After the algorithm was done all commit graphic items are assigned | ||
| coordinates based on its row and column multiplied by the coefficient. | ||
| """ |
There was a problem hiding this comment.
Thanks for the detailed comment, much appreciated!
davvid
added a commit
that referenced
this pull request
Jan 18, 2017
Related-to: #648 Signed-off-by: David Aguilar <davvid@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current commit layout algorithm returns bad looking graph in several
sophisticated configurations. Defects could be found near commits
a049169
2462221
of Git Cola graph. The ambiguous edge overlapping may confuse a user.
The new algorithm is free of this defects. No other defects were found in
Git Cola graph too. While overall appearance still could be improved there
are no confusing configuration noticed.
The layout technique description is presented by comments in the code.