Depth-first traversal column reset #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Efimov Vasily <real@ispras.ru>
The propagate_frontier assumes that frontier column is always defined. KeyError exception is an indicator of an error in another part of the grid layout algorithm. So, do not except KeyError to get the error as soon as possible. The hotfix may be applied again for temporary error elimination. At the other hand, defining frontier in this place too, complicates the algorithm logic. Signed-off-by: Efimov Vasily <real@ispras.ru>
|
Thanks for the detailed descriptions. Makes perfect sense |
davvid
added a commit
to davvid/git-cola
that referenced
this pull request
Feb 7, 2017
* laerreal/dft_reset: dag: revert hotfix of undefined frontier dag: use depth-first traversal to reset columns Signed-off-by: David Aguilar <davvid@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've investigated the issue about KeyError in propagate_frontier. That was 52-th column in may case. Sometimes the error had not appeared. Hence, I guess the error is related to non-determinism of incremental graph loading. All children of currently added nodes are assigned a column. But, some of them might not be reset because they are not added yet. During consequent iteration the algorithm assumes that corresponding column is allocated because it was not reset. This time the error raises.
I suggest to use depth-first traversal of graph during reset. Complexity of the algorithm seems to remain O(N) while this guaranties that all nodes are reset.
I had not got an error during 10 runs. However, it would be nice if you check it at your side.