fix radios action #662

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
2 participants
@javierrodriguezcuevas
Contributor

javierrodriguezcuevas commented Feb 9, 2017

Hi,
This solves a strange behavior. When you clicked on the radio buttons in 'rev_radio_group' to list the branches it did not get the clicked element correctly and it was necessary to click the element twice to get correctly.

@davvid

Please sign-off on your commits. We follow the same process as the Git project; read the link below for an explanation for why we ask for sign-offs and what they convey.

https://github.com/git-cola/git-cola/blob/master/CONTRIBUTING.md#sign-your-work

In cola, you can do Ctrl+m to go into Amend mode, and Ctrl+i to add a signoff to the commit message.

Push up an amended commit and I'll merge this in. Thanks for the fix!

javierrodriguezcuevas added some commits Feb 9, 2017

fix radios action
Signed-off-by: javierrodriguezcuevas <javierrodriguezcuevas@gmail.com>
@javierrodriguezcuevas

This comment has been minimized.

Show comment
Hide comment
@javierrodriguezcuevas

javierrodriguezcuevas Feb 10, 2017

Contributor

Hi again, sorry for not signing before. I followed your instructions and I hope it is now correct.
If it is not I will make a new pull request with "sign-off" commit.

Thanks you!

Contributor

javierrodriguezcuevas commented Feb 10, 2017

Hi again, sorry for not signing before. I followed your instructions and I hope it is now correct.
If it is not I will make a new pull request with "sign-off" commit.

Thanks you!

@davvid

This comment has been minimized.

Show comment
Hide comment
@davvid

davvid Feb 11, 2017

Member

Thanks again!

Member

davvid commented Feb 11, 2017

Thanks again!

davvid added a commit to davvid/git-cola that referenced this pull request Feb 11, 2017

Merge pull request #662 from javierrodriguezcuevas/bug/create_branch_…
…radiobuttons

* javierrodriguezcuevas/bug/create_branch_radiobuttons:
  fix radios action

Signed-off-by: David Aguilar <davvid@gmail.com>

@davvid davvid closed this in 575c885 Feb 11, 2017

@davvid

This comment has been minimized.

Show comment
Hide comment
@davvid

davvid Feb 11, 2017

Member

I merged the commit rather than the tip of the branch since it had merges in there that we didn't need, just noting that this was merged, but github won't notice since I didn't merge the tip of the branch.

Member

davvid commented Feb 11, 2017

I merged the commit rather than the tip of the branch since it had merges in there that we didn't need, just noting that this was merged, but github won't notice since I didn't merge the tip of the branch.

@javierrodriguezcuevas javierrodriguezcuevas deleted the javierrodriguezcuevas:bug/create_branch_radiobuttons branch Feb 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment