Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix radios action #662

Closed
wants to merge 3 commits into from

Conversation

zisato
Copy link
Contributor

@zisato zisato commented Feb 9, 2017

Hi,
This solves a strange behavior. When you clicked on the radio buttons in 'rev_radio_group' to list the branches it did not get the clicked element correctly and it was necessary to click the element twice to get correctly.

Copy link
Member

@davvid davvid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign-off on your commits. We follow the same process as the Git project; read the link below for an explanation for why we ask for sign-offs and what they convey.

https://github.com/git-cola/git-cola/blob/master/CONTRIBUTING.md#sign-your-work

In cola, you can do Ctrl+m to go into Amend mode, and Ctrl+i to add a signoff to the commit message.

Push up an amended commit and I'll merge this in. Thanks for the fix!

Signed-off-by: javierrodriguezcuevas <javierrodriguezcuevas@gmail.com>
@zisato
Copy link
Contributor Author

zisato commented Feb 10, 2017

Hi again, sorry for not signing before. I followed your instructions and I hope it is now correct.
If it is not I will make a new pull request with "sign-off" commit.

Thanks you!

@davvid
Copy link
Member

davvid commented Feb 11, 2017

Thanks again!

davvid added a commit to davvid/git-cola that referenced this pull request Feb 11, 2017
…_branch_radiobuttons

* javierrodriguezcuevas/bug/create_branch_radiobuttons:
  fix radios action

Signed-off-by: David Aguilar <davvid@gmail.com>
@davvid davvid closed this in 575c885 Feb 11, 2017
@davvid
Copy link
Member

davvid commented Feb 11, 2017

I merged the commit rather than the tip of the branch since it had merges in there that we didn't need, just noting that this was merged, but github won't notice since I didn't merge the tip of the branch.

@zisato zisato deleted the bug/create_branch_radiobuttons branch February 11, 2017 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants