New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editremotes: update referenced attribute, fixes #684 #685

Merged
merged 1 commit into from Apr 20, 2017

Conversation

Projects
None yet
2 participants
@Vdragon
Contributor

Vdragon commented Apr 19, 2017

In commit 98303c5 AddRemoteWidget's name attribute has been renamed to
remote_name, however RemoteEditor.add() isn't updated accordingly,
causing add new remote operation failed silently. This commit completes
the attribute name change.

Signed-off-by: V字龍 Vdragon.Taiwan@gmail.com

editremotes: update referenced attribute, fixes #684
In commit 98303c5 AddRemoteWidget's `name` attribute has been renamed to
`remote_name`, however RemoteEditor.add() isn't updated accordingly,
causing add new remote operation failed silently.  This commit completes
the attribute name change.

Signed-off-by: V字龍 <Vdragon.Taiwan@gmail.com>

davvid added a commit to davvid/git-cola that referenced this pull request Apr 20, 2017

Merge pull request git-cola#685 from Vdragon/fix-issue-684-unable-add…
…-remote

* Vdragon/fix-issue-684-unable-add-remote:
  editremotes: update referenced attribute, fixes git-cola#684

Signed-off-by: David Aguilar <davvid@gmail.com>

@davvid davvid merged commit 9ba1afb into git-cola:master Apr 20, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment