Prevent overlapping with terminated branch #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The explanation is in the script. Signed-off-by: Efimov Vasily <real@ispras.ru>
Signed-off-by: Efimov Vasily <real@ispras.ru>
davvid
added a commit
to davvid/git-cola
that referenced
this pull request
Apr 25, 2017
* laerreal/fixes: dag: prevent overlapping of a new branch and terminated one dag: add test reproducing branch overlapping Signed-off-by: David Aguilar <davvid@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tag overlapping prevention algorithm can cause an overlapping with terminated branch.
The reproducing script with explanation is added by this patch series. The scripts build the graph represented below.
After the bug is fixed the graph becomes as represented below.
Another kind of overlapping is seen (edges of branches b6 and b7). But it is up to other bug that is being investigated.