status: Scroll current item into view when selection changes #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When moving selection up/down with keyboard in a long file list the selected item goes out of view and there's no way to tell what file the current diff corresponds to. This change ensures that latest selected item is always visible. The horizontal scrolling is preserved as it was implemented before. See also issue git-cola#494 and pull request git-cola#178 for related discussion. Signed-off-by: Petr Gladkikh <petrglad@gmail.com>
|
The build fails on 2.6, should I fix this? How? |
davvid
added a commit
to davvid/git-cola
that referenced
this pull request
May 26, 2018
* PetrGlad/scroll-into-view: status: Scroll current item into view when selection changes Signed-off-by: David Aguilar <davvid@gmail.com>
|
Nicely done. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When moving selection up/down with keyboard in a long file list the
selected item goes out of view and there's no way to tell which file the
current diff corresponds to.
This change ensures that latest selected item is always visible.
The horizontal scrolling is preserved as it was implemented before.
See also issue #494 and pull request #178 for related discussion.
Signed-off-by: Petr Gladkikh petrglad@gmail.com