New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

status: Scroll current item into view when selection changes #828

Merged
merged 1 commit into from May 26, 2018

Conversation

Projects
None yet
2 participants
@PetrGlad
Contributor

PetrGlad commented May 23, 2018

When moving selection up/down with keyboard in a long file list the
selected item goes out of view and there's no way to tell which file the
current diff corresponds to.
This change ensures that latest selected item is always visible.
The horizontal scrolling is preserved as it was implemented before.

See also issue #494 and pull request #178 for related discussion.

Signed-off-by: Petr Gladkikh petrglad@gmail.com

status: Scroll current item into view when selection changes
When moving selection up/down with keyboard in a long file list the
selected item goes out of view and there's no way to tell what file the
current diff corresponds to.
This change ensures that latest selected item is always visible.
The horizontal scrolling is preserved as it was implemented before.

See also issue #494 and pull request #178 for related discussion.

Signed-off-by: Petr Gladkikh <petrglad@gmail.com>
@PetrGlad

This comment has been minimized.

Show comment
Hide comment
@PetrGlad

PetrGlad May 25, 2018

Contributor

The build fails on 2.6, should I fix this? How?

Contributor

PetrGlad commented May 25, 2018

The build fails on 2.6, should I fix this? How?

davvid added a commit to davvid/git-cola that referenced this pull request May 26, 2018

Merge pull request #828 from PetrGlad/scroll-into-view
* PetrGlad/scroll-into-view:
  status: Scroll current item into view when selection changes

Signed-off-by: David Aguilar <davvid@gmail.com>
@davvid

This comment has been minimized.

Show comment
Hide comment
@davvid

davvid May 26, 2018

Member

Nicely done. Thanks!

Member

davvid commented May 26, 2018

Nicely done. Thanks!

@davvid davvid merged commit af51b9f into git-cola:master May 26, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment