New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmds: Remove redundant query message #840

Merged
merged 1 commit into from Jun 15, 2018

Conversation

Projects
None yet
2 participants
@Vdragon
Contributor

Vdragon commented Jun 11, 2018

The first line of the body in the "Rename Remote" dialog is redundant and
unnecessary, this patch removes the message and changes the interaction
to a question.

screenshot_20180611_230034

The new interaction choice might not be sane though, please review.

Fixes #838.

Refer-to: Redundant query message · Issue #838 · git-cola/git-cola #838
Signed-off-by: 林博仁 Buo.Ren.Lin@gmail.com

cmds: Remove redundant query message
The first line of the body in the "Rename Remote" dialog is redundant and
unnecessary, this patch removes the message and changes the interaction
to a question.

The new interaction choice might not be sane though, please review.

Fixes #838.

Refer-to: Redundant query message · Issue #838 · git-cola/git-cola <#838>
Signed-off-by: 林博仁 <Buo.Ren.Lin@gmail.com>
@davvid

This comment has been minimized.

Show comment
Hide comment
@davvid

davvid Jun 15, 2018

Member

The simpler dialog is nicer. It's good UX to leave the button label as "Rename Remote", rather than an opaque "Yes" / "No" choice, so I'll fix that up post-merge. Thanks

Member

davvid commented Jun 15, 2018

The simpler dialog is nicer. It's good UX to leave the button label as "Rename Remote", rather than an opaque "Yes" / "No" choice, so I'll fix that up post-merge. Thanks

davvid added a commit to davvid/git-cola that referenced this pull request Jun 15, 2018

Merge pull request #840 from Vdragon/patch-issue-838
* Vdragon/patch-issue-838:
  cmds: Remove redundant query message

Signed-off-by: David Aguilar <davvid@gmail.com>

davvid added a commit to davvid/git-cola that referenced this pull request Jun 15, 2018

cmds: use "Rename Remote" for the action button label
Keep the original UX while still simplifying the dialog by restoring the
"Rename Remote" label on the action button.

Related-to: #838 #840
Signed-off-by: David Aguilar <davvid@gmail.com>

@davvid davvid merged commit 58e2cb0 into git-cola:master Jun 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment