cmds: Remove redundant query message #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first line of the body in the "Rename Remote" dialog is redundant and unnecessary, this patch removes the message and changes the interaction to a question. The new interaction choice might not be sane though, please review. Fixes git-cola#838. Refer-to: Redundant query message · Issue git-cola#838 · git-cola/git-cola <git-cola#838> Signed-off-by: 林博仁 <Buo.Ren.Lin@gmail.com>
|
The simpler dialog is nicer. It's good UX to leave the button label as "Rename Remote", rather than an opaque "Yes" / "No" choice, so I'll fix that up post-merge. Thanks |
davvid
added a commit
to davvid/git-cola
that referenced
this pull request
Jun 15, 2018
* Vdragon/patch-issue-838: cmds: Remove redundant query message Signed-off-by: David Aguilar <davvid@gmail.com>
davvid
added a commit
to davvid/git-cola
that referenced
this pull request
Jun 15, 2018
Keep the original UX while still simplifying the dialog by restoring the "Rename Remote" label on the action button. Related-to: git-cola#838 git-cola#840 Signed-off-by: David Aguilar <davvid@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first line of the body in the "Rename Remote" dialog is redundant and
unnecessary, this patch removes the message and changes the interaction
to a question.
The new interaction choice might not be sane though, please review.
Fixes #838.
Refer-to: Redundant query message · Issue #838 · git-cola/git-cola #838
Signed-off-by: 林博仁 Buo.Ren.Lin@gmail.com