New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: Avoid word separation in parameter expansion #858

Merged
merged 2 commits into from Jul 4, 2018

Conversation

Projects
None yet
2 participants
@Lin-Buo-Ren
Contributor

Lin-Buo-Ren commented Jul 4, 2018

The build will break when either DESTDIR or prefix contains spaces, this patch wraps the expansion with quotes to avoid the word separations.

Lin-Buo-Ren added some commits Jul 4, 2018

Quote DESTDIR expansion to avoid word splitting
Build breaks when DESTDIR contains spaces.

Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
Quote $prefix expansion to avoid word splitting
Build should breaks when DESTDIR contains spaces.

Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>

davvid added a commit to davvid/git-cola that referenced this pull request Jul 4, 2018

Merge pull request #858 from Lin-Buo-Ren/patch-make-destdir-avoid-wor…
…d-separation

* Lin-Buo-Ren/patch-make-destdir-avoid-word-separation:
  Quote $prefix expansion to avoid word splitting
  Quote DESTDIR expansion to avoid word splitting

Resolves #858
Signed-off-by: David Aguilar <davvid@gmail.com>

@davvid davvid merged commit 3aa973e into git-cola:master Jul 4, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Lin-Buo-Ren Lin-Buo-Ren deleted the Lin-Buo-Ren:patch-make-destdir-avoid-word-separation branch Jul 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment