Make icons sharp in HiDPI screen #932
Conversation
cola/app.py
Outdated
| @@ -178,6 +178,8 @@ def __init__(self, context, argv, locale=None, | |||
|
|
|||
| self.context = context | |||
| self._install_hidpi_config() | |||
| # Make icons sharp in HiDPI screen | |||
| self._app.setAttribute(Qt.AA_UseHighDpiPixmaps, True) | |||
There was a problem hiding this comment.
This makes sense to be in the ColaQApplication constructor instead.
We still support PyQt4, so please check hasattr(Qt, 'AA_UseHighDpiPixmaps') before using it here.
This code probably doesn't work as written, and should be hitting a traceback -- self._app hasn't been assigned yet -- it's getting assigned on the line below.
|
I updated the code as you commented. Before:
After: System icons, like the settings icon (from Breeze theme) look pretty nice. But app's SVG icons are still not clear. |
|
I think the SVG icons need some changes.
Could I also modify all icons? Thanks! |
|
Yes, please, that would be awesome. |
* guoyunhe/patch-1: Make icons sharp in HiDPI screen Signed-off-by: David Aguilar <davvid@gmail.com>
|
I've merged the current state as-is and speculatively updated the release notes to mention the upcoming updates to the icons. I'll merge make sure to merge that in asap. Thanks again |
|
Can you share your updated |
|
@davvid You can try this branch https://github.com/guoyunhe/git-cola/tree/make-icons-sharp What I did is to change the size and view port of SVG files to 22x22px. Tested with @1.5 scale factor. |
|
Thanks, I've now done this to all the icons, including the ones in the |
No description provided.