dag: add set_revtext_gather_paths #981
Conversation
There was a problem hiding this comment.
Thanks for this enhancement, this is a great idea.
Small design consideration -- is this a setting that is really global, or should it be like some of the other preferences that can be both global and per-repo?
My intuition is telling me that this really feels like something that may be repo-specific (large vs. small repos) so it might make more sense to implement it similarly to the global/local settings that are present in the Preferences window. That way users can keep this feature enabled by default, and selectively disable it when working in large repos.
Let me know what you think.
|
Thanks for the comments! I would like to redesign this. Yes, this switch should be a local setting. But I didn't explore the code carefully before, so I simply follow the 'Lock Layout'.. Right, it is quite slow for projects with many files.. |
In case project has many files. Signed-off-by: xhl <xieofxie@126.com>
|
Now it totally depends on model.cfg.get(prefs.AUTOCOMPLETE_PATHS) |
Related-to: git-cola#981 Signed-off-by: David Aguilar <davvid@gmail.com>
* xieofxie/gather_path: dag: add set_revtext_gather_paths Signed-off-by: David Aguilar <davvid@gmail.com>
In case project has many files.
I'm sorry that I'm working on Windows so I didn't run make check and make pot.