Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve worktree .git files to repository .git directory #642

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

jkylling
Copy link
Contributor

@jkylling jkylling commented Aug 12, 2023

Context

Fix #639
I have not tested this change end to end.

Contributor Checklist

  • Added relevant integration or unit tests to verify the changes
  • Update the Readme or any other documentation (including relevant Javadoc)
  • Ensured that tests pass locally: mvn clean package
  • Ensured that the code meets the current checkstyle coding style definition: mvn clean verify -Pcheckstyle -Dmaven.test.skip=true -B

@xkrogen
Copy link

xkrogen commented Aug 14, 2023

Thanks for the investigation @jkylling ! Not the most elegant fix, but practical and does seem to solve the issue

@TheSnoozer
Copy link
Collaborator

Do you have better suggestions @xkrogen?

@xkrogen
Copy link

xkrogen commented Aug 16, 2023

I took a quick read through the Details section for git-worktree and the worktree-related stuff in gitrepository-layout. It seems like this should work if we assume the GIT_DIR and GIT_COMMON_DIR environment variables aren't set. Not sure if we should consider them here?

There is also the potential situation where .git is a text file containing a gitpath spec, instead of a directory. Also not sure if git-commit-id handles this situation generally; if so, should we also handle that here?

@jkylling
Copy link
Contributor Author

jkylling commented Oct 1, 2023

@TheSnoozer I've gone through the contributor checklist and fixed the check style violations. Do you think we should merge this?

@TheSnoozer TheSnoozer added this to the 7.0.0 milestone Oct 3, 2023
@TheSnoozer TheSnoozer merged commit 4feba8d into git-commit-id:master Oct 3, 2023
21 checks passed
@TheSnoozer
Copy link
Collaborator

Thanks again for your contribution! Merged now.

@xkrogen
Copy link

xkrogen commented Oct 20, 2023

Hey @TheSnoozer just curious when you expect this to go into a release? I'm not familiar with the release lifecycle of this project, just wondering when I'll be able to adopt it downstream.

Big thanks to both of you btw :)

@TheSnoozer
Copy link
Collaborator

The release cycle is to wait until someone mentions they want a release ;-)

Will do that as soon as I have time (sorry this project is still only my free time) :-)

@TheSnoozer
Copy link
Collaborator

Released now as 7.0.0 via #623.

@xkrogen
Copy link

xkrogen commented Oct 23, 2023

Heh awesome ... Thanks so much @TheSnoozer !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin fails in git worktree even when native git is used
3 participants