Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter in function maybeGeneratePropertiesFile in order to choose to escape unicode or not. #11

Merged
merged 1 commit into from Oct 7, 2022

Conversation

gary258796
Copy link
Contributor

Context

By #10 , we need a parameter to set in order to not escape unicode if we want.

Contributor Checklist

  • Added relevant integration or unit tests to verify the changes
  • Update the Readme or any other documentation (including relevant Javadoc)
  • Ensured that tests pass locally: mvn clean package
  • Ensured that the code meets the current checkstyle coding style definition: mvn clean verify -Pcheckstyle -Dmaven.test.skip=true -B

@TheSnoozer TheSnoozer merged commit cb3375a into git-commit-id:master Oct 7, 2022
@TheSnoozer
Copy link
Contributor

Thanks for your investigation and contribution to the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants