Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checksums for 0.10.0 #15

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Fix checksums for 0.10.0 #15

merged 1 commit into from
Dec 7, 2023

Conversation

noizwaves
Copy link
Contributor

Problem

I support developer environments at Gusto, and we started seeing this error when running updates:

==> Fetching git-duet/tap/git-duet
==> Downloading https://github.com/git-duet/git-duet/releases/download/0.10.0/darwin_arm64.tar.gz
Already downloaded: /Users/andrew.herr/Library/Caches/Homebrew/downloads/344e74d514a80174e411a3761672def8ca7701c8e06a614ea16d70fa836e37fd--darwin_arm64.tar.gz
Error: SHA256 mismatch
Expected: e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855
  Actual: edf84e298029571b5f377993abb50d3c553cdb953cc3ff1acf136802d5e40165

Fixes #14

Solution

Update SHA values from fresh GitHub downloads:

❯ sha256sum ~/Downloads/darwin_arm64.tar.gz
edf84e298029571b5f377993abb50d3c553cdb953cc3ff1acf136802d5e40165  /Users/adam.neumann/Downloads/darwin_arm64.tar.gz

❯ sha256sum ~/Downloads/darwin_amd64.tar.gz
fbc42f6388dbccb7f080992241e03de4c61bf4e2fec0fa875f5e8b4f403788dd  /Users/adam.neumann/Downloads/darwin_amd64.tar.gz

❯ sha256sum ~/Downloads/linux_amd64.tar.gz
c6db0838dddbb76604bdf02dc086dd0fb105096b4b468438a16cf4bcb40ad6f0  /Users/adam.neumann/Downloads/linux_amd64.tar.gz

Copy link

@corsonknowles corsonknowles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for offering this fix to the community.

@corsonknowles
Copy link

@jszwedko Hi! Looks like you are the local expert and maintainer here. Can you take a look at this?

@medoror-mo
Copy link

@jszwedko can you merge this? Will there be a version bump afterwards?

Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this quick fix @noizwaves !

I see how I messed that up. I had used curl ... | sha256sum but neglected that the URLs for the release assets return redirects that need to be followed. I validated these checksums.

@jszwedko jszwedko merged commit f591738 into git-duet:master Dec 7, 2023
@noizwaves noizwaves deleted the patch-1 branch December 7, 2023 04:41
@noizwaves
Copy link
Contributor Author

Fantastic, many thanks @jszwedko!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update fails with checksum error
5 participants