Merge pull request #259 from mjcheetham/fix-ghes-modes

Ensure the PAT option is always offered for GHES instances
git-ecosystem · Jan 6, 2021 · 8f96623 · 8f96623
2 parents c7a7719 + 556c635
commit 8f96623
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/shared/GitHub.Tests/GitHubHostProviderTests.cs b/src/shared/GitHub.Tests/GitHubHostProviderTests.cs
@@ -121,10 +121,10 @@ public async Task GitHubHostProvider_GetSupportedAuthenticationModes(string uriS
 
 
         [Theory]
-        [InlineData("https://example.com", null, "0.1", false, AuthenticationModes.None)]
-        [InlineData("https://example.com", null, "0.1", true, AuthenticationModes.Basic)]
-        [InlineData("https://example.com", null, "100.0", false, AuthenticationModes.OAuth)]
-        [InlineData("https://example.com", null, "100.0", true, AuthenticationModes.Basic | AuthenticationModes.OAuth)]
+        [InlineData("https://example.com", null, "0.1", false, AuthenticationModes.Pat)]
+        [InlineData("https://example.com", null, "0.1", true, AuthenticationModes.Basic | AuthenticationModes.Pat)]
+        [InlineData("https://example.com", null, "100.0", false, AuthenticationModes.OAuth | AuthenticationModes.Pat)]
+        [InlineData("https://example.com", null, "100.0", true, AuthenticationModes.All)]
         public async Task GitHubHostProvider_GetSupportedAuthenticationModes_WithMetadata(string uriString, string gitHubAuthModes,
             string installedVersion, bool verifiablePasswordAuthentication, AuthenticationModes expectedModes)
         {

diff --git a/src/shared/GitHub/GitHubHostProvider.cs b/src/shared/GitHub/GitHubHostProvider.cs
@@ -243,7 +243,7 @@ internal async Task<AuthenticationModes> GetSupportedAuthenticationModesAsync(Ur
             {
                 GitHubMetaInfo metaInfo = await _gitHubApi.GetMetaInfoAsync(targetUri);
 
-                var modes = AuthenticationModes.None;
+                var modes = AuthenticationModes.Pat;
                 if (metaInfo.VerifiablePasswordAuthentication)
                 {
                     modes |= AuthenticationModes.Basic;