Skip to content

Commit

Permalink
install from source: publish before attempting install (#987)
Browse files Browse the repository at this point in the history
The changes from 3978b0e introduced a bug in the install from source
workflow - we were attempting to copy binaries before publishing them!
Fixing with this change.

Validated with [this passing
workflow](https://github.com/ldennington/git-credential-manager/actions/runs/3652773502)
in my fork.
  • Loading branch information
ldennington committed Dec 8, 2022
2 parents ef8e38e + 8a36ea6 commit 9ef3fcc
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions src/linux/Packaging.Linux/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@ fi
OUTDIR="$INSTALLER_OUT/$CONFIGURATION"
PAYLOAD="$OUTDIR/payload"

# Lay out payload
"$INSTALLER_SRC/layout.sh" --configuration="$CONFIGURATION" || exit 1

if [ $INSTALL_FROM_SOURCE = true ]; then
INSTALL_LOCATION="/usr/local"
mkdir -p "$INSTALL_LOCATION"
Expand Down Expand Up @@ -74,8 +77,7 @@ if [ $INSTALL_FROM_SOURCE = true ]; then

echo "Install complete."
else
# Layout and pack
"$INSTALLER_SRC/layout.sh" --configuration="$CONFIGURATION" --output="$PAYLOAD" --symbol-output="$" || exit 1
# Pack
"$INSTALLER_SRC/pack.sh" --configuration="$CONFIGURATION" --payload="$PAYLOAD" --version="$VERSION" || exit 1
fi

Expand Down

0 comments on commit 9ef3fcc

Please sign in to comment.