Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide options to override MS authentication flows #210

Closed
mjcheetham opened this issue Nov 6, 2020 · 0 comments · Fixed by #212
Closed

Provide options to override MS authentication flows #210

mjcheetham opened this issue Nov 6, 2020 · 0 comments · Fixed by #212
Labels
auth:microsoft Specific to Microsoft AAD/MSA authentication enhancement New feature or request platform:windows Specific to the Windows platform

Comments

@mjcheetham
Copy link
Collaborator

At the moment we force users to use a particular Microsoft authentication flow (via MSAL) based on the current environment.

  • If there's an interactive session..
    • ..on Windows we use the embedded browser flow.
    • ..on non-Windows..
      • ..with a native UI helper we use that helper.
      • ..without a native UI helper we use the system browser.
  • If there's no interactive session we use device code flow.

The user should be free to select the flow they prefer, rather than forcing them to use the one we deem "best". The system browser or device-code flows can be used enable scenarios like FIDO or Windows Hello, which may be desirable.

Visual Studio already offers an option to change the authentication flow.

image

This can be implemented pretty easily by introduction of a GCM_MSAUTH_FLOW/credential.msAuthFlow or similar setting that is respected by the MicrosoftAuthentication component.

Note: Use of the system browser requires a localhost redirect be set in the AAD configuration. We would need to ensure this was set correctly.

@mjcheetham mjcheetham added enhancement New feature or request platform:windows Specific to the Windows platform auth:microsoft Specific to Microsoft AAD/MSA authentication labels Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auth:microsoft Specific to Microsoft AAD/MSA authentication enhancement New feature or request platform:windows Specific to the Windows platform
Projects
None yet
1 participant