Allow user to override which interactive authentication flow used for MS auth #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjcheetham
added
enhancement
derrickstolee
approved these changes
Nov 9, 2020
src/shared/Microsoft.Git.CredentialManager/Authentication/AuthenticationBase.cs
Outdated
Show resolved
Hide resolved
Comment on lines
+133
to
+141
| case MicrosoftAuthenticationFlowType.Auto: | ||
| if (CanUseEmbeddedWebView()) | ||
| goto case MicrosoftAuthenticationFlowType.EmbeddedWebView; | ||
|
|
||
| if (CanUseSystemWebView(app, redirectUri)) | ||
| goto case MicrosoftAuthenticationFlowType.SystemWebView; | ||
|
|
||
| // Fall back to device code flow | ||
| goto case MicrosoftAuthenticationFlowType.DeviceCode; |
There was a problem hiding this comment.
The existence of gotos makes me want to restructure this code. However, this switch is so carefully constructed, that the alternatives actually look worse. Kudos on finding a good use for goto.
There was a problem hiding this comment.
Yeah, this sort of "have several options, and an 'auto' choice that may pick one of those options" pattern is best served with a switch with goto case, IMO.
It's the only time I've found goto is acceptable; plus goto case feels safer that a random label.
This same pattern is already present in the GitHubAuthentication class for selecting the type of auth flow (user/pass or OAuth) or letting it auto-detect.
Allow the user to override which Microsoft authentication flow to use when interaction is required. The options available are: - embedded web view - system web view - device code Previously we always picked one of these flows (or used a native external helper) to use. In some instances it may be desirable for the user to force a particular flow, for instance to take advantage of browser sign-in state or OS integrations by using 'system'. If no option is set, or `auto` is selected the existing behaviour is preserved (we pick for the user).
Use the localhost redirect URI specified in the VS AAD application configuration. The localhost option allows us to use the system web view, whereas 'urn:ieft:wg:oauth:2.0:oob' does not.
mjcheetham
force-pushed
the
msauth-choice
branch
from
02045ae
to
151fec2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the user to override which Microsoft authentication flow to use when interaction is required.
The options available are:
Previously we always picked one of these flows (or used a native external helper) to use. In some instances it may be desirable for the user to force a particular flow, for instance to take advantage of browser sign-in state or OS integrations by using 'system'.
If no option is set, or
autois selected the existing behaviour is preserved (we pick for the user).Fixes #210