Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small addition to GitHub enterprise detection #219

Closed
AlexanderLanin opened this issue Nov 14, 2020 · 1 comment · Fixed by #241
Closed

Small addition to GitHub enterprise detection #219

AlexanderLanin opened this issue Nov 14, 2020 · 1 comment · Fixed by #241
Labels
enhancement New feature or request

Comments

@AlexanderLanin
Copy link
Contributor

AlexanderLanin commented Nov 14, 2020

Currently GitHub ist auto detected by domain github.com.
While you could work forever on a clever heuristic, it does seem safe to make a minimal adjustment and detect github.* as GitHub.
E.g. github.myorganization.com

As far as I can tell this is https://github.com/microsoft/Git-Credential-Manager-Core/blob/c3a543a1352dba953e027f7a92ee4a94b2293a22/src/shared/GitHub/GitHubHostProvider.cs#L63 and https://github.com/microsoft/Git-Credential-Manager-Core/blob/c3a543a1352dba953e027f7a92ee4a94b2293a22/src/shared/GitHub.Tests/GitHubHostProviderTests.cs#L14

@AlexanderLanin
Copy link
Contributor Author

This is particularly annoying not just because of lack of OAuth in the generic login. But because the generic login is asking for a password which is disabled on GitHub.
Of course this is trivially fixable by config, but it affects too many users in my case. Someone always has trouble setting up a correct config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant