Detect github.my-company-server.com as GitHub #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjcheetham
requested changes
Dec 7, 2020
There was a problem hiding this comment.
Sorry for the delay here @AlexanderLanin. This seems like a reasonable addition which shouldn't trip up many people, if any (those who have a "github.example.tld" remote that isn't GHES - and then they can always force the generic provider).
Just a few changes regarding string comparison and one extra check in substring string handling (just to be extra safe).
Co-authored-by: Matthew John Cheetham <mjcheetham@outlook.com>
Uri converts to lowercase.
mjcheetham
approved these changes
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect github[.subdomain].domain.tld as GitHub in order to better support GitHub Enterprise Server.
Prior to this patch a manual configuration of https://github.com/microsoft/Git-Credential-Manager-Core/blob/master/docs/configuration.md#credentialprovider is required.
Closes #219
Unfortunately it's unclear whether this will catch any significant portion of such setups as the urls are not known. But it does seem reasonable and it does catch my use case :-)