for wslview: Browser authentication disabled if DISPLAY variable is not set #878
Closed
2 of 9 tasks
Assignees
Labels
auth-issue
An issue authenticating to a host
gui
Specific to graphical user interface controls
platform:wsl
Specific to Windows Subsystem for Linux
Comments
mjcheetham
added
platform:wsl
mjcheetham
added a commit
that referenced
this issue
Mar 15, 2023
Today we're gating browser-based authentication mechanisms behind a GUI-possible session, which isn't 100% correct. When inside of a WSL session, without WSLg enabled, it is still possible to launch a web browser in the hosting Windows session. Split the determination between "GUI session" and "browser possible", and add the special case for WSL inside an interactive Windows session. Things are complicated here because it is possible to SSH in to the WSL instance from outside of the Windows host, meaning the Windows session also doesn't have UI. This case we still need to prevent browser-based options. In order to detect these cases we need to 'punch out' to the Windows host and run a script/cmdlet to determine the session type. Fixes #878
|
With the merging of #1148 we now differentiate between GUI sessions inside/outside of WSL, and know if we can launch a browser via The feature will be available in the next GCM release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
wslview is supported
see here:
https://github.com/GitCredentialManager/git-credential-manager/blob/7c4381cb754538367a7d0b33ecf3550ca6b5fa79/src/shared/Core/BrowserUtils.cs#L43
wslview does not require a DISPLAY variable.
However, the posix session manager checks for the DISPLAY variable.
https://github.com/GitCredentialManager/git-credential-manager/blob/7c4381cb754538367a7d0b33ecf3550ca6b5fa79/src/shared/Core/Interop/Posix/PosixSessionManager.cs#L13
Therefore, the browser is disabled.
https://github.com/GitCredentialManager/git-credential-manager/blob/dea7cb1afdab43f3852dd897c58b52ae3b6722a3/src/shared/GitHub/GitHubAuthentication.cs#L70
Possibly broken in this commit.
28f487a
Suggestion:
Bypass the check if wslview is present.
workaround:
Set the display variable.
Which version of GCM are you using?
From a terminal, run
git credential-manager-core --versionand paste the output.2.0.785.29792
Which Git host provider are you trying to connect to?
Can you access the remote repository directly in the browser using the remote URL?
Any private repo will work.
Expected behavior
Browser pops up when authenticating.
Actual behavior
Only show oauth device code login.
Logs
N/A
The text was updated successfully, but these errors were encountered: