Return only unique accounts from credential stores #1369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If may be possible for multiple credentials for the same user account to exist in any credential store. To avoid issues with redundant account selection prompts we should ensure duplicate accounts are removed from the results of `ICredentialStore.GetAccounts`. Call `.Distinct()` or use a `HashSet` where appropriate on all implementation of `ICredentialStore.GetAccounts`.
ldennington
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If may be possible for multiple credentials for the same user account to exist in any credential store. To avoid issues with redundant account selection prompts we should ensure duplicate accounts are removed from the results of
ICredentialStore.GetAccounts.Call
.Distinct()or use aHashSetwhere appropriate on all implementation ofICredentialStore.GetAccounts.If there are multiple credentials for the same account, we'd only ever be able to retrieve the first enumerated credential regardless because our matching logic is to return to first credential that matches.
Fixes #1368