Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: include payload only in osx-arm64 tarball #1458

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

mjcheetham
Copy link
Collaborator

@mjcheetham mjcheetham commented Nov 1, 2023

Only include the payload (binaries) in the tar.gz archive for osx-arm64. Previously this was including the parent directory that captured the payload, pkg, and symbol subdirectories and children.

The osx-x64 tar.gz archive is already correctly only containing the payload.

Illustration of discrepancy

% tree -L 1 gcm-osx-arm64-2.4.0
gcm-osx-arm64-2.4.0
├── payload
├── pkg
└── symbols

4 directories, 0 files
% tree -L 1 gcm-osx-x64-2.4.0  
gcm-osx-x64-2.4.0
├── Atlassian.Bitbucket.dll
├── Avalonia.Base.dll
├── Avalonia.Controls.dll
├── Avalonia.DesignerSupport.dll
├── Avalonia.Desktop.dll
├── Avalonia.Dialogs.dll
├── Avalonia.FreeDesktop.dll
├── Avalonia.Markup.Xaml.dll
...

Only include the payload (binaries) in the tar.gz archive for osx-arm64.
Previously this was including the parent directory that captured the
payload, pkg, and symbol subdirectories and children.

The osx-x64 tar.gz archive is already correctly only containing the
payload.
@mjcheetham mjcheetham added bug A bug in Git Credential Manager engineering Refactoring or build changes labels Nov 1, 2023
@mjcheetham mjcheetham requested a review from a team November 1, 2023 19:37
@mjcheetham mjcheetham self-assigned this Nov 1, 2023
@mjcheetham mjcheetham merged commit 76ab2bc into git-ecosystem:main Nov 1, 2023
6 checks passed
@mjcheetham mjcheetham deleted the fix-osx-arm64-tarball branch November 1, 2023 19:46
mjcheetham added a commit that referenced this pull request Nov 1, 2023
**Changes:**

_Since 2.4.0:_

- Fix macOS ARM64 tarball contents (#1458)

_Since 2.3.x:_

- Add support for managed identity and service principals in Azure Repos
(#1372)
- Support universal Gitea OAuth app configuration (#1442)
- Set default generic OAuth redirect URI value (#1444)
- Drop WPF helpers on Windows (#1417)
- Add software rendering override for Windows (#1445, #1453)
- Recognise GitLab hosts via WWW-Authenticate header (#1428)
- Recognise Bitbucket hosts via WWW-Authenticate header (#1441)
- Support GitHub Gist remote URLs (#1402)
- Update to Avalonia 11.x (#1383)
- Documentation updates (#1416)
- Drop unnecessary .NET Framework-specific code (#1447)
- Updates to release process (#1386, #1381)
- Update code signing certificates (#1431)
@Topikc58

This comment was marked as spam.

@Nidacoke

This comment was marked as off-topic.

@EimalShirzai

This comment was marked as spam.

@EimalShirzai

This comment was marked as spam.

@EimalShirzai

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug in Git Credential Manager engineering Refactoring or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants