Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New release to fix Linux web browser launching #181

Merged
merged 3 commits into from
Sep 25, 2020
Merged

New release to fix Linux web browser launching #181

merged 3 commits into from
Sep 25, 2020

Commits on Sep 25, 2020

  1. env: introduce TryLocateExecutable method 

    Introduce a `TryX` method version of the existing `LocateExecutable`
method on `IEnvironment`, for locating executables with `which` and
`where.exe`.
    @mjcheetham
    mjcheetham committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    d5f8045 View commit details
    Browse the repository at this point in the history

  2. oauth: disconnect streams from xdg-open 

    When using the `Process` class to open the user's default browser on
Linux, utilities like `xdg-open` are used. Some of these utilities
do not disconnect child processes from our standard input/output/error
streams. At the same time, browsers like Chromium like to write to
stdout and stderr, which gets fed back to Git or the user's terminal,
respectively. The latter looks messy, and the former causes Git to fail.

On Linux, we instead manually locate a suitable 'shell execute' utility
and launch them directly - this way we can redirect the standard
output/error streams.

For Windows and macOS, this is not an issue and we continue to use the
Framework code to do 'shell execute'.
    @mjcheetham
    mjcheetham committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    96950a2 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #180 from mjcheetham/fix-webopen 

    Disconnect standard output/error streams from `xdg-open` and friends
    @mjcheetham
    mjcheetham committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    13f53e0 View commit details
    Browse the repository at this point in the history