GitHub: add PAT support #231
Conversation
|
Hi @AlexanderLanin, thanks for the PR to add explicit PAT support to the GitHub provider and UI! We have been working on a branch with such a feature, but have taken a slightly different approach with plumbing the new mode through the different layers, and how this is presented in the UI. We'll be ready to share this soon. |
|
So there is no need to continue on the PR? I was about to verify it works with GHES and PATs. |
|
Hi @AlexanderLanin, Thanks again for the contribution. As you may have seen, with PR #236 the ability to add a PAT explicitly (GitHub.com and GHES) will be available in the next release. As a result I will be closing this PR. If you have any other issues or improvement suggestions please do contribute by issue or PR. Sorry that this particular PR didn't make it in given the existing work we had lined up at the same time. We do usually accept contributions where appropriate 😃 ❤️ |
As shown in #222 current GCM Core does not only not properly show PAT. It even doesn't work with PAT at all. This PR is supposed to fix both issues.
Minor points of #222 are not yet addressed like showing "What is a PAT?" and "Click here to generate a PAT".