Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET 5.0 #288

Merged
merged 3 commits into from
Feb 25, 2021
Merged

.NET 5.0 #288

merged 3 commits into from
Feb 25, 2021

Conversation

NN---
Copy link
Contributor

@NN--- NN--- commented Feb 16, 2021

Copy link
Contributor

@derrickstolee derrickstolee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just pointed out one small bit. We will want to wait for @mjcheetham who knows a bit about why the Windows version is still on .NET Framework (or is it Standard?).

.github/ISSUE_TEMPLATE/auth-problem.md Outdated Show resolved Hide resolved
@NN---
Copy link
Contributor Author

NN--- commented Feb 17, 2021

I just pointed out one small bit. We will want to wait for @mjcheetham who knows a bit about why the Windows version is still on .NET Framework (or is it Standard?).

#113

@normanlorrain
Copy link

normanlorrain commented Feb 19, 2021

A URL in README.md is incorrect (.NET should point to https://dotnet.microsoft.com/):
Line 9 should be
[Git Credential Manager Core](https://github.com/microsoft/Git-Credential-Manager-Core) (GCM Core) is a secure Git credential helper built on [.NET](https://dotnet.microsoft.com/) that runs on Windows and macOS. Linux support is in an early preview.

@NN---
Copy link
Contributor Author

NN--- commented Feb 22, 2021

A URL in README.md is incorrect (.NET should point to dotnet.microsoft.com):
Line 9 should be

@normalian I can change, but probably it is better to be done as a separate PR.

@NN---
Copy link
Contributor Author

NN--- commented Feb 22, 2021

Fixed here and as a separate PR #293

Copy link
Collaborator

@mjcheetham mjcheetham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is and looks great thanks @NN--- ! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants