Move all interop code under Interop namespace
#29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjcheetham
added
platform:osx
jamill
reviewed
Apr 24, 2019
src/shared/Microsoft.Git.CredentialManager/Interop/Windows/Native/Advapi32.cs
Show resolved
Hide resolved
jamill
approved these changes
Apr 24, 2019
Move all the platform specific interop code to the `Interop` namespace and also group the P/Invoke calls into classes representing the modules/libraries/headers the original C functions live in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move all the platform specific interop code to the
Interopnamespace and also group the P/Invoke calls into classes representing the modules/libraries/headers the original C functions live in.This PR contains only moves and renames.
This change is a precursor to a subsequent PR which will add native TTY interaction for UNIX-like and Windows platforms.. of which there is more interop code. This refactor helps readability of that change.